From 963d7950fd7eeff9e2bafb4154ca83ed66c2f748 Mon Sep 17 00:00:00 2001
From: Linus Nordberg <linus@nordu.net>
Date: Mon, 14 Mar 2011 13:32:59 +0100
Subject: (rs_packet_destroy): Free unconditionally.

---
 lib/packet.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

(limited to 'lib/packet.c')

diff --git a/lib/packet.c b/lib/packet.c
index 3519c1c..a7e09f6 100644
--- a/lib/packet.c
+++ b/lib/packet.c
@@ -188,11 +188,10 @@ rs_packet_frpkt (struct rs_packet *pkt)
 void
 rs_packet_destroy (struct rs_packet *pkt)
 {
-  if (pkt)
-    {
-      // FIXME: memory leak! TODO: free all attributes
-      rad_free (&pkt->rpkt);
-      rs_free (pkt->conn->ctx, pkt);
-    }
-}
+  assert (pkt);
+  assert (pkt->conn);
+  assert (pkt->conn->ctx);
 
+  rad_free (&pkt->rpkt); /* Note: This frees the VALUE_PAIR's too.  */
+  rs_free (pkt->conn->ctx, pkt);
+}
-- 
cgit v1.1