summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorLinus Nordberg <linus@nordberg.se>2015-05-05 21:07:31 +0200
committerLinus Nordberg <linus@nordberg.se>2015-05-05 21:07:31 +0200
commit4debec0f967d429f3cc9011eff898bc5e5585bda (patch)
treec2631aa6318660c0392985266a2a00ee1985c562 /src
parentbbccb14d1be52a3375b44da7c68323c30c0ce985 (diff)
Dialyzer clean.
Diffstat (limited to 'src')
-rw-r--r--src/db.erl6
-rw-r--r--src/frontend.erl3
-rw-r--r--src/index.erl4
-rw-r--r--src/plop.erl4
4 files changed, 10 insertions, 7 deletions
diff --git a/src/db.erl b/src/db.erl
index b0c6eaa..f53cd19 100644
--- a/src/db.erl
+++ b/src/db.erl
@@ -71,12 +71,12 @@ set_treesize(Size) ->
ok.
-spec get_by_indices(integer(), integer(), {sorted, true|false}) ->
- [{non_neg_integer(), binary(), binary()}].
+ [{non_neg_integer(), binary(), notfetched}].
get_by_indices(Start, End, {sorted, _Sorted}) ->
get_by_indices_helper(Start, End).
--spec get_by_index(binary()) -> notfound |
- {non_neg_integer(), binary(), binary()}.
+-spec get_by_index(non_neg_integer()) ->
+ {non_neg_integer(), binary(), noentry | binary()}.
get_by_index(Index) ->
LeafHash = leafhash_for_index(Index),
Entry = entry_for_leafhash(LeafHash),
diff --git a/src/frontend.erl b/src/frontend.erl
index 2689956..172cc23 100644
--- a/src/frontend.erl
+++ b/src/frontend.erl
@@ -132,9 +132,12 @@ check_entry(LeafHash, Index) ->
ok
end.
+-spec fetchmissingentries(non_neg_integer()) -> [binary() | noentry].
fetchmissingentries(Index) ->
lists:reverse(fetchmissingentries(Index, [])).
+-spec fetchmissingentries(non_neg_integer(), [binary() | noentry]) ->
+ [binary() | noentry].
fetchmissingentries(Index, Acc) ->
lager:debug("index ~p", [Index]),
case db:leafhash_for_index(Index) of
diff --git a/src/index.erl b/src/index.erl
index e4979b3..a91c17c 100644
--- a/src/index.erl
+++ b/src/index.erl
@@ -78,7 +78,7 @@ add(Basepath, Index, Entry, Syncflag) when is_binary(Entry), size(Entry) == ?ENT
sync(Basepath) ->
util:fsync([Basepath, filename:dirname(Basepath)]).
--spec addlast_nosync(string(), integer()) -> ok.
+-spec addlast_nosync(string(), binary()) -> ok.
addlast_nosync(Basepath, Entry) ->
add_nosync(Basepath, last, Entry).
@@ -115,7 +115,7 @@ get(Basepath, Index) ->
Entry
end.
--spec getrange(string(), integer(), integer()) -> [binary()].
+-spec getrange(string(), integer(), integer()) -> [binary()] | noentry.
getrange(Basepath, Start, End) when Start =< End ->
lager:debug("path ~p start ~p end ~p", [Basepath, Start, End]),
case file:open(Basepath, [read, binary]) of
diff --git a/src/plop.erl b/src/plop.erl
index 42f068e..1f9ddd0 100644
--- a/src/plop.erl
+++ b/src/plop.erl
@@ -175,8 +175,8 @@ inclusion_and_entry(Index, TreeSize) ->
{notfound, "Unknown index"};
true ->
case db:get_by_index(Index) of
- notfound ->
- {notfound, "Unknown index"}; % FIXME: include Index
+ {I, _MTLHash, noentry} ->
+ {notfound, io:format("Unknown index ~p", [I])};
{I, _MTLHash, Entry} ->
{ok, Entry, ht:path(I, TreeSize - 1)}
end